Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align d3-shape version on bar with other packages #2076

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

pauldijou
Copy link
Contributor

@pauldijou pauldijou commented Jul 13, 2022

I've been facing hoisting issues while using nivo on a monorepo app with Lerna / Yarn workspaces, leading to runtime errors due to an incorrect React context, probably because the @nivo/core module was duplicated at the root of the app and inside each project.

Wondering if that could be because @nivo/bar is not using the same minor version for d3-shape as other packages.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 271c844:

Sandbox Source
nivo Configuration

@plouc plouc merged commit 95a81d5 into plouc:master Sep 8, 2022
@plouc
Copy link
Owner

plouc commented Sep 8, 2022

Good catch @pauldijou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants